[common] 2.0.4 (#392)

.github/renovate.json5

@@ -29,13 +29,15 @@
       "updateTypes": ["minor"],
       "bumpVersion": "minor",
       "labels": ["dependency/minor"],
-      "packageNames": ["common"]
+      "packageNames": ["common"],
+      "groupName": ["internal minor dep"]
     },
     {
       "updateTypes": ["patch"],
       "bumpVersion": "patch",
       "labels": ["dependency/patch"],
-      "packageNames": ["common"]
+      "packageNames": ["common"],
+      "groupName": ["internal patch dep"]
     },
     //
     // Other library deps
@@ -54,6 +56,7 @@
       "bumpVersion": "minor",
       "labels": ["dependency/minor"],
       "excludePackageNames": ["common"],
+      "groupName": ["external minor dep"],
       "schedule": [
         "every 2 months on the first day of the month"
       ]
@@ -63,6 +66,7 @@
       "bumpVersion": "patch",
       "labels": ["dependency/patch"],
       "excludePackageNames": ["common"],
+      "groupName": ["external patch dep"],
       "schedule": [
         "every 1 months on the first day of the month"
       ]

.github/workflows/lint-test.yaml

@@ -38,13 +38,8 @@ jobs:
 
       - name: Run chart-testing (lint)
         id: lint
-        run: ct lint --config .github/ct.yaml
+        run: ct lint --config .github/ct.yaml --excluded-charts ""
-        if: steps.list-changed.outputs.changed == 'true'
+        if: steps.list-changed.outputs.common == 'true' || steps.list-changed.outputs.common == 'true'
-
-      - name: Run chart-testing (lint common-test)
-        run: |
-          ct lint --config .github/ct.yaml --charts 'charts/common-test'
-        if: steps.list-changed.outputs.common == 'true'
 
       - name: Create kind cluster
         uses: helm/kind-action@v1.1.0

charts/common-test/Chart.yaml

@@ -1,7 +1,7 @@
 apiVersion: v2
 name: common-test
 description: Helper chart to test different use cases of the common library
-version: 1.0.1
+version: 1.0.2
 keywords:
   - k8s-at-home
   - common

charts/common-test/ci/basic-values.yaml

@@ -9,3 +9,11 @@ service:
 
 ingress:
   enabled: true
+
+probes:
+  liveness:
+    enabled: true
+  readiness:
+    enabled: true
+  startup:
+    enabled: true

charts/common/CHANGELOG.md

@@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [2.0.4]
+
+### Fixed
+
+- `periodSeconds` now works for all probe types.
+
 ## [2.0.0]
 
 ### Changed
@@ -24,6 +30,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 This is the last version before starting this changelog. All sorts of cool stuff was changed, but only `git log` remembers what that was :slightly_frowning_face:
 
+[2.0.4]: https://github.com/k8s-at-home/charts/tree/common-2.0.4/charts/common
+
 [2.0.0]: https://github.com/k8s-at-home/charts/tree/common-2.0.0/charts/common
 
 [1.7.0]: https://github.com/k8s-at-home/charts/tree/common-1.7.0/charts/common

charts/common/Chart.yaml

@@ -2,11 +2,11 @@ apiVersion: v2
 name: common
 description: Function library for k8s-at-home charts
 type: library
-version: 2.0.3
+version: 2.0.4
 keywords:
   - k8s-at-home
   - common
 home: https://github.com/k8s-at-home/charts/tree/master/charts/common
 maintainers:
-  - name: BJW-S
+  - name: bjw-s
-    email: me@juggels.online
+    email: me@bjw-s.dev

charts/common/templates/lib/controller/_probes.tpl

@@ -15,6 +15,7 @@ Probes selection logic.
       {{- printf "initialDelaySeconds: %v" $probe.spec.initialDelaySeconds  | nindent 2 }}
       {{- printf "failureThreshold: %v" $probe.spec.failureThreshold  | nindent 2 }}
       {{- printf "timeoutSeconds: %v" $probe.spec.timeoutSeconds  | nindent 2 }}
+      {{- printf "periodSeconds: %v" $probe.spec.periodSeconds | nindent 2 }}
     {{- end }}
   {{- end }}
 {{- end }}

charts/common/values.yaml

@@ -66,6 +66,7 @@ probes:
     spec:
       initialDelaySeconds: 30
       failureThreshold: 5
+      periodSeconds: 10
       timeoutSeconds: 10
 
   readiness:
@@ -77,6 +78,7 @@ probes:
     spec:
       initialDelaySeconds: 30
       failureThreshold: 5
+      periodSeconds: 10
       timeoutSeconds: 10
 
   startup:
@@ -89,6 +91,7 @@ probes:
       initialDelaySeconds: 5
       failureThreshold: 30
       periodSeconds: 10
+      timeoutSeconds: 10
 
 service:
   enabled: true