From 57f4f5d7bfcfff769ce52af3b222e7674212e935 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?B=E1=B4=87=CA=80=C9=B4=E1=B4=85=20S=E1=B4=84=CA=9C?= =?UTF-8?q?=E1=B4=8F=CA=80=C9=A2=E1=B4=87=CA=80s?= <6213398+bjw-s@users.noreply.github.com> Date: Wed, 16 Dec 2020 20:34:01 +0100 Subject: [PATCH] [common] 2.0.4 (#392) --- .github/renovate.json5 | 8 ++++++-- .github/workflows/lint-test.yaml | 9 ++------- charts/common-test/Chart.yaml | 2 +- charts/common-test/ci/basic-values.yaml | 8 ++++++++ charts/common/CHANGELOG.md | 8 ++++++++ charts/common/Chart.yaml | 6 +++--- charts/common/templates/lib/controller/_probes.tpl | 1 + charts/common/values.yaml | 13 ++++++++----- 8 files changed, 37 insertions(+), 18 deletions(-) diff --git a/.github/renovate.json5 b/.github/renovate.json5 index f35bbeff..9fb0b4df 100644 --- a/.github/renovate.json5 +++ b/.github/renovate.json5 @@ -29,13 +29,15 @@ "updateTypes": ["minor"], "bumpVersion": "minor", "labels": ["dependency/minor"], - "packageNames": ["common"] + "packageNames": ["common"], + "groupName": ["internal minor dep"] }, { "updateTypes": ["patch"], "bumpVersion": "patch", "labels": ["dependency/patch"], - "packageNames": ["common"] + "packageNames": ["common"], + "groupName": ["internal patch dep"] }, // // Other library deps @@ -54,6 +56,7 @@ "bumpVersion": "minor", "labels": ["dependency/minor"], "excludePackageNames": ["common"], + "groupName": ["external minor dep"], "schedule": [ "every 2 months on the first day of the month" ] @@ -63,6 +66,7 @@ "bumpVersion": "patch", "labels": ["dependency/patch"], "excludePackageNames": ["common"], + "groupName": ["external patch dep"], "schedule": [ "every 1 months on the first day of the month" ] diff --git a/.github/workflows/lint-test.yaml b/.github/workflows/lint-test.yaml index 252cac02..7a9695ca 100644 --- a/.github/workflows/lint-test.yaml +++ b/.github/workflows/lint-test.yaml @@ -38,13 +38,8 @@ jobs: - name: Run chart-testing (lint) id: lint - run: ct lint --config .github/ct.yaml - if: steps.list-changed.outputs.changed == 'true' - - - name: Run chart-testing (lint common-test) - run: | - ct lint --config .github/ct.yaml --charts 'charts/common-test' - if: steps.list-changed.outputs.common == 'true' + run: ct lint --config .github/ct.yaml --excluded-charts "" + if: steps.list-changed.outputs.common == 'true' || steps.list-changed.outputs.common == 'true' - name: Create kind cluster uses: helm/kind-action@v1.1.0 diff --git a/charts/common-test/Chart.yaml b/charts/common-test/Chart.yaml index ef0c0f3a..8fc54bde 100644 --- a/charts/common-test/Chart.yaml +++ b/charts/common-test/Chart.yaml @@ -1,7 +1,7 @@ apiVersion: v2 name: common-test description: Helper chart to test different use cases of the common library -version: 1.0.1 +version: 1.0.2 keywords: - k8s-at-home - common diff --git a/charts/common-test/ci/basic-values.yaml b/charts/common-test/ci/basic-values.yaml index 55d4876a..8a6f19fd 100644 --- a/charts/common-test/ci/basic-values.yaml +++ b/charts/common-test/ci/basic-values.yaml @@ -9,3 +9,11 @@ service: ingress: enabled: true + +probes: + liveness: + enabled: true + readiness: + enabled: true + startup: + enabled: true diff --git a/charts/common/CHANGELOG.md b/charts/common/CHANGELOG.md index 5b249ca9..b6927e97 100644 --- a/charts/common/CHANGELOG.md +++ b/charts/common/CHANGELOG.md @@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). +## [2.0.4] + +### Fixed + +- `periodSeconds` now works for all probe types. + ## [2.0.0] ### Changed @@ -24,6 +30,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 This is the last version before starting this changelog. All sorts of cool stuff was changed, but only `git log` remembers what that was :slightly_frowning_face: +[2.0.4]: https://github.com/k8s-at-home/charts/tree/common-2.0.4/charts/common + [2.0.0]: https://github.com/k8s-at-home/charts/tree/common-2.0.0/charts/common [1.7.0]: https://github.com/k8s-at-home/charts/tree/common-1.7.0/charts/common diff --git a/charts/common/Chart.yaml b/charts/common/Chart.yaml index dbd77086..a9ab0420 100644 --- a/charts/common/Chart.yaml +++ b/charts/common/Chart.yaml @@ -2,11 +2,11 @@ apiVersion: v2 name: common description: Function library for k8s-at-home charts type: library -version: 2.0.3 +version: 2.0.4 keywords: - k8s-at-home - common home: https://github.com/k8s-at-home/charts/tree/master/charts/common maintainers: - - name: BJW-S - email: me@juggels.online + - name: bjw-s + email: me@bjw-s.dev diff --git a/charts/common/templates/lib/controller/_probes.tpl b/charts/common/templates/lib/controller/_probes.tpl index a07a66ba..84c0fdf7 100644 --- a/charts/common/templates/lib/controller/_probes.tpl +++ b/charts/common/templates/lib/controller/_probes.tpl @@ -15,6 +15,7 @@ Probes selection logic. {{- printf "initialDelaySeconds: %v" $probe.spec.initialDelaySeconds | nindent 2 }} {{- printf "failureThreshold: %v" $probe.spec.failureThreshold | nindent 2 }} {{- printf "timeoutSeconds: %v" $probe.spec.timeoutSeconds | nindent 2 }} + {{- printf "periodSeconds: %v" $probe.spec.periodSeconds | nindent 2 }} {{- end }} {{- end }} {{- end }} diff --git a/charts/common/values.yaml b/charts/common/values.yaml index a6ddb7e1..35e95aa8 100644 --- a/charts/common/values.yaml +++ b/charts/common/values.yaml @@ -61,34 +61,37 @@ probes: enabled: true ## Set this to true if you wish to specify your own livenessProbe custom: false - ## The spec field contains the values for the default livenessProbe. + ## The spec field contains the values for the default livenessProbe. ## If you selected custom: true, this field holds the definition of the livenessProbe. spec: initialDelaySeconds: 30 failureThreshold: 5 + periodSeconds: 10 timeoutSeconds: 10 readiness: enabled: true ## Set this to true if you wish to specify your own readinessProbe custom: false - ## The spec field contains the values for the default readinessProbe. + ## The spec field contains the values for the default readinessProbe. ## If you selected custom: true, this field holds the definition of the readinessProbe. spec: initialDelaySeconds: 30 failureThreshold: 5 + periodSeconds: 10 timeoutSeconds: 10 startup: enabled: false ## Set this to true if you wish to specify your own startupProbe custom: false - ## The spec field contains the values for the default startupProbe. + ## The spec field contains the values for the default startupProbe. ## If you selected custom: true, this field holds the definition of the startupProbe. spec: initialDelaySeconds: 5 failureThreshold: 30 periodSeconds: 10 + timeoutSeconds: 10 service: enabled: true @@ -120,7 +123,7 @@ service: # type: ClusterIP # # Specify the default port information # port: - # port: + # port: # # name defaults to http # name: # protocol: TCP @@ -243,7 +246,7 @@ addons: # Set the VPN container securityContext securityContext: capabilities: - add: + add: - NET_ADMIN - SYS_MODULE