From 820042639cfa9517ff59278b283b8a8cc2c537d1 Mon Sep 17 00:00:00 2001 From: Nathan Pawelek Date: Mon, 13 Dec 2021 08:00:14 -0600 Subject: [PATCH] [tdarr] Add ffmpegPath environment override (#1308) * [tdarr] Add ffmpegPath environment override This change adds and environment override for ffmpegPath. If unset, the tdarr node container will use the default binary that ships with tdarr. Using `""` may cause detection issues with hardware passthrough (i915), but will remain backwards compatible with the container default. Signed-off-by: Nathan Pawelek --- charts/stable/tdarr/Chart.yaml | 2 +- charts/stable/tdarr/README.md | 7 +++++++ charts/stable/tdarr/README_CHANGELOG.md.gotmpl | 6 ++++++ charts/stable/tdarr/templates/common.yaml | 2 ++ charts/stable/tdarr/values.yaml | 2 ++ 5 files changed, 18 insertions(+), 1 deletion(-) diff --git a/charts/stable/tdarr/Chart.yaml b/charts/stable/tdarr/Chart.yaml index a1de1526..4e8f2049 100644 --- a/charts/stable/tdarr/Chart.yaml +++ b/charts/stable/tdarr/Chart.yaml @@ -2,7 +2,7 @@ apiVersion: v2 appVersion: 2.00.10 description: Tdarr is a self hosted web-app for automating media library transcode/remux management and making sure your files are exactly how you need them to be in terms of codecs/streams/containers etc. name: tdarr -version: 4.1.3 +version: 4.2.0 keywords: - transcoding - remux diff --git a/charts/stable/tdarr/README.md b/charts/stable/tdarr/README.md index 8130f108..aae558b4 100644 --- a/charts/stable/tdarr/README.md +++ b/charts/stable/tdarr/README.md @@ -80,6 +80,7 @@ N/A | env.serverIP | string | `"0.0.0.0"` | tdarr server binding address | | env.serverPort | string | `"{{ .Values.service.main.ports.server.port }}"` | tdarr server listening port | | env.webUIPort | string | `"{{ .Values.service.main.ports.http.port }}"` | tdarr web UI listening port (same as Service port) | +| env.ffmpegPath | string | `""` | Override the pre-compiled ffmpeg binary | | image.pullPolicy | string | `"IfNotPresent"` | image pull policy | | image.repository | string | `"haveagitgat/tdarr"` | image repository | | image.tag | string | `"2.00.10"` | image tag | @@ -103,6 +104,12 @@ All notable changes to this application Helm chart will be documented in this fi The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). +### [4.2.0] + +#### Changed + +- Add an environment override for `ffmpegPath`. If unset, the tdarr node container will use the default binary that ships with tdarr. Using `""` may cause detection issues with hardware passthrough (i915), but will be backwards backwards compatible with the container default. + ### [4.1.3] #### Changed diff --git a/charts/stable/tdarr/README_CHANGELOG.md.gotmpl b/charts/stable/tdarr/README_CHANGELOG.md.gotmpl index 5017182f..d0f70faf 100644 --- a/charts/stable/tdarr/README_CHANGELOG.md.gotmpl +++ b/charts/stable/tdarr/README_CHANGELOG.md.gotmpl @@ -9,6 +9,12 @@ All notable changes to this application Helm chart will be documented in this fi The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). +### [4.2.0] + +#### Changed + +- Add an environment override for `ffmpegPath`. If unset, the tdarr node container will use the default binary that ships with tdarr. Using `""` may cause detection issues with hardware passthrough (i915), but will be backwards backwards compatible with the container default. + ### [4.1.3] #### Changed diff --git a/charts/stable/tdarr/templates/common.yaml b/charts/stable/tdarr/templates/common.yaml index 30fa40d2..dc4cb6e6 100644 --- a/charts/stable/tdarr/templates/common.yaml +++ b/charts/stable/tdarr/templates/common.yaml @@ -17,6 +17,8 @@ additionalContainers: value: "localhost" - name: serverPort value: "{{ .Values.service.main.ports.server.port }}" + - name: ffmpegPath + value: {{ default "" .Values.env.ffmpegPath }} volumeMounts: {{ if .Values.persistence.config.enabled }} - name: config diff --git a/charts/stable/tdarr/values.yaml b/charts/stable/tdarr/values.yaml index 71d6af44..8d3850e1 100644 --- a/charts/stable/tdarr/values.yaml +++ b/charts/stable/tdarr/values.yaml @@ -24,6 +24,8 @@ env: serverIP: 0.0.0.0 # -- tdarr server listening port serverPort: "{{ .Values.service.main.ports.server.port }}" + # -- Allow override for the pre-compiled tdarr ffmpeg binary + ffmpegPath: "" # -- Configures service settings for the chart. # @default -- See values.yaml