From 761d9996f6a4cc5a8581bd0b7183486b967a0918 Mon Sep 17 00:00:00 2001
From: Vegetto <git@angelnu.com>
Date: Sun, 14 Mar 2021 14:26:09 +0100
Subject: [PATCH] use higher port for webhook (#663)

Co-authored-by: angelnu <git@angelnucom>
---
 charts/dnsmadeeasy-webhook/Chart.yaml         |  2 +-
 charts/dnsmadeeasy-webhook/README.md          | 23 ++++++++++++++++---
 charts/dnsmadeeasy-webhook/README.md.gotmpl   |  2 --
 .../README_CHANGELOG.md.gotmpl                | 16 +++++++++++++
 charts/dnsmadeeasy-webhook/values.yaml        |  3 ++-
 5 files changed, 39 insertions(+), 7 deletions(-)

diff --git a/charts/dnsmadeeasy-webhook/Chart.yaml b/charts/dnsmadeeasy-webhook/Chart.yaml
index 4e868c70..15b4bd3d 100644
--- a/charts/dnsmadeeasy-webhook/Chart.yaml
+++ b/charts/dnsmadeeasy-webhook/Chart.yaml
@@ -2,7 +2,7 @@ apiVersion: v2
 appVersion: 1.0.0
 description: Cert-Manager Webhook for DNSMadeEasy
 name: dnsmadeeasy-webhook
-version: 1.1.0
+version: 1.1.1
 keywords:
 - cert-manager
 - dnsmadeeasy
diff --git a/charts/dnsmadeeasy-webhook/README.md b/charts/dnsmadeeasy-webhook/README.md
index d4dd05da..f95e3c63 100644
--- a/charts/dnsmadeeasy-webhook/README.md
+++ b/charts/dnsmadeeasy-webhook/README.md
@@ -1,6 +1,6 @@
 # dnsmadeeasy-webhook
 
-![Version: 1.0.0](https://img.shields.io/badge/Version-1.0.0-informational?style=flat-square) ![AppVersion: 1.0.0](https://img.shields.io/badge/AppVersion-1.0.0-informational?style=flat-square)
+![Version: 1.1.1](https://img.shields.io/badge/Version-1.1.1-informational?style=flat-square) ![AppVersion: 1.0.0](https://img.shields.io/badge/AppVersion-1.0.0-informational?style=flat-square)
 
 Cert-Manager Webhook for DNSMadeEasy
 
@@ -17,7 +17,7 @@ Cert-Manager Webhook for DNSMadeEasy
 
 | Repository | Name | Version |
 |------------|------|---------|
-| https://k8s-at-home.com/charts/ | common | 3.1.0 |
+| https://library-charts.k8s-at-home.com | common | 1.0.0 |
 
 ## TL;DR
 
@@ -77,7 +77,7 @@ N/A
 | additionalVolumeMounts[0].mountPath | string | `"/tls"` |  |
 | additionalVolumeMounts[0].name | string | `"certs"` |  |
 | additionalVolumeMounts[0].readOnly | bool | `true` |  |
-| args | string | `"[\"--tls-cert-file=/tls/tls.crt\",\"--tls-private-key-file=/tls/tls.key\"]"` |  |
+| args | string | `"[\"--tls-cert-file=/tls/tls.crt\",\"--tls-private-key-file=/tls/tls.key\",\"--secure-port=4443\"]"` |  |
 | certManager.namespace | string | `"cert-manager"` | Namespace where the cert-manager operator was installed to |
 | certManager.serviceAccountName | string | `"cert-manager"` | Service account used by the cert-manager |
 | groupName | string | `"acme.mycompany.com"` | The GroupName here is used to identify your company or business unit that created this webhook. This name will need to be referenced in each Issuer's `webhook` stanza to inform cert-manager of where to send ChallengePayload resources in order to solve the DNS01 challenge. This group name should be **unique**, hence using your own company's domain here is recommended. |
@@ -101,6 +101,7 @@ N/A
 | probes.startup.spec.httpGet.scheme | string | `"HTTPS"` |  |
 | service.port.name | string | `"https"` |  |
 | service.port.port | int | `443` |  |
+| service.port.targetPort | int | `4443` |  |
 
 ## Changelog
 
@@ -124,6 +125,22 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 
 [1.0.0]: #1.0.0
 
+### [1.1.1]
+
+#### Added
+
+- N/A
+
+#### Changed
+
+- Use port 4443 for application
+
+#### Removed
+
+- N/A
+
+[1.1.1]: #1.1.1
+
 ## Support
 
 - See the [Docs](https://docs.k8s-at-home.com/our-helm-charts/getting-started/)
diff --git a/charts/dnsmadeeasy-webhook/README.md.gotmpl b/charts/dnsmadeeasy-webhook/README.md.gotmpl
index e39382b7..8b868671 100644
--- a/charts/dnsmadeeasy-webhook/README.md.gotmpl
+++ b/charts/dnsmadeeasy-webhook/README.md.gotmpl
@@ -27,8 +27,6 @@ https://k8s-at-home.com/charts/
 {{- define "custom.dependencies" -}}
 ## Dependencies
 
-This chart depends on the [cert-manager](https://cert-manager.io/docs/installation/kubernetes/).
-
 {{ template "chart.requirementsTable" . }}
 {{- end -}}
 
diff --git a/charts/dnsmadeeasy-webhook/README_CHANGELOG.md.gotmpl b/charts/dnsmadeeasy-webhook/README_CHANGELOG.md.gotmpl
index 7c6cc526..f00f20cf 100644
--- a/charts/dnsmadeeasy-webhook/README_CHANGELOG.md.gotmpl
+++ b/charts/dnsmadeeasy-webhook/README_CHANGELOG.md.gotmpl
@@ -24,4 +24,20 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 - N/A
 
 [1.0.0]: #1.0.0
+
+### [1.1.1]
+
+#### Added
+
+- N/A
+
+#### Changed
+
+- Use port 4443 for application
+
+#### Removed
+
+- N/A
+
+[1.1.1]: #1.1.1
 {{- end -}}
diff --git a/charts/dnsmadeeasy-webhook/values.yaml b/charts/dnsmadeeasy-webhook/values.yaml
index 63ba4b80..f56cbc22 100644
--- a/charts/dnsmadeeasy-webhook/values.yaml
+++ b/charts/dnsmadeeasy-webhook/values.yaml
@@ -24,7 +24,7 @@ image:
   # -- Image tag
   tag: v1.0.0
 
-args: '["--tls-cert-file=/tls/tls.crt","--tls-private-key-file=/tls/tls.key"]'
+args: '["--tls-cert-file=/tls/tls.crt","--tls-private-key-file=/tls/tls.key","--secure-port=4443"]'
 
 additionalVolumeMounts:
 - name: certs
@@ -60,4 +60,5 @@ probes:
 service:
   port:
     name: https
+    targetPort: 4443
     port: 443