eric/duckdb-ui
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Always compute UI_EXTENSION_GIT_SHA

Browse Source
This commit is contained in:
Yves
2025-02-17 18:20:25 +01:00
parent 1698c5cb7c
commit d03b87dfce
3 changed files with 19 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/http_server.cpp
View File

@@ -94,10 +94,10 @@ bool HttpServer::Start(const uint16_t local_port, const std::string &remote_url,
local_port_ = local_port;
remote_url_ = remote_url;
ddb_instance_ = ddb_instance;
#ifndef EXT_VERSION_UI
#error "EXT_VERSION_UI must be defined"
#ifndef UI_EXTENSION_GIT_SHA
#error "UI_EXTENSION_GIT_SHA must be defined"
#endif
user_agent_ = StringUtil::Format("duckdb-ui/%s(%s)", EXT_VERSION_UI, DuckDB::Platform());
user_agent_ = StringUtil::Format("duckdb-ui/%s(%s)", UI_EXTENSION_GIT_SHA, DuckDB::Platform());
event_dispatcher_ = make_uniq<EventDispatcher>();
thread_ = make_uniq<std::thread>(&HttpServer::Run, this);
return true;

4
src/ui_extension.cpp
View File

@@ -115,8 +115,8 @@ std::string UiExtension::Name() {
}
std::string UiExtension::Version() const {
#ifdef EXT_VERSION_UI
return EXT_VERSION_UI;
#ifdef UI_EXTENSION_GIT_SHA
return UI_EXTENSION_GIT_SHA;
#else
return "";
#endif