eric/duckdb-ui
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove obsolete functions

Browse Source
This commit is contained in:
Yves
2025-02-21 10:26:59 +01:00
parent 86d061a605
commit 4408269681
2 changed files with 0 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/include/utils/helpers.hpp
View File

@@ -74,22 +74,9 @@ void RegisterTF(DatabaseInstance &instance, const char *name) {
ExtensionUtil::RegisterFunction(instance, tf); ExtensionUtil::RegisterFunction(instance, tf);
} }
template <typename Func, Func func>
void RegisterTFWithArgs(DatabaseInstance &instance, const char *name,
vector<LogicalType> arguments,
table_function_bind_t bind) {
TableFunction tf(name, arguments, internal::TableFunc<Func, func>, bind,
RunOnceTableFunctionState::Init);
ExtensionUtil::RegisterFunction(instance, tf);
}
} // namespace internal } // namespace internal
#define RESISTER_TF(name, func) \ #define RESISTER_TF(name, func) \
internal::RegisterTF<decltype(&func), &func>(instance, name) internal::RegisterTF<decltype(&func), &func>(instance, name)
#define RESISTER_TF_ARGS(name, args, func, bind) \
internal::RegisterTFWithArgs<decltype(&func), &func>(instance, name, args, \
bind)
} // namespace duckdb } // namespace duckdb

36
src/ui_extension.cpp
View File

@@ -70,39 +70,6 @@ std::string StopUIServerFunction(ClientContext &context) {
: "UI server already stopped"; : "UI server already stopped";
} }
// Connected notification
struct NotifyConnectedFunctionData : public TableFunctionData {
NotifyConnectedFunctionData(std::string _token) : token(_token) {}
std::string token;
};
static unique_ptr<FunctionData>
NotifyConnectedBind(ClientContext &, TableFunctionBindInput &input,
vector<LogicalType> &out_types, vector<string> &out_names) {
if (input.inputs[0].IsNull()) {
throw BinderException("Must provide a token");
}
out_names.emplace_back("result");
out_types.emplace_back(LogicalType::VARCHAR);
return make_uniq<NotifyConnectedFunctionData>(input.inputs[0].ToString());
}
std::string NotifyConnectedFunction(ClientContext &context,
TableFunctionInput &input) {
auto &inputs = input.bind_data->Cast<NotifyConnectedFunctionData>();
ui::HttpServer::GetInstance(context)->SendConnectedEvent(inputs.token);
return "OK";
}
std::string NotifyCatalogChangedFunction(ClientContext &context) {
ui::HttpServer::GetInstance(context)->SendCatalogChangedEvent();
return "OK";
}
// - connected notification
unique_ptr<FunctionData> SingleBoolResultBind(ClientContext &, unique_ptr<FunctionData> SingleBoolResultBind(ClientContext &,
TableFunctionBindInput &, TableFunctionBindInput &,
vector<LogicalType> &out_types, vector<LogicalType> &out_types,
@@ -151,9 +118,6 @@ static void LoadInternal(DatabaseInstance &instance) {
RESISTER_TF("start_ui", StartUIFunction); RESISTER_TF("start_ui", StartUIFunction);
RESISTER_TF("start_ui_server", StartUIServerFunction); RESISTER_TF("start_ui_server", StartUIServerFunction);
RESISTER_TF("stop_ui_server", StopUIServerFunction); RESISTER_TF("stop_ui_server", StopUIServerFunction);
RESISTER_TF("notify_ui_catalog_changed", NotifyCatalogChangedFunction);
RESISTER_TF_ARGS("notify_ui_connected", {LogicalType::VARCHAR},
NotifyConnectedFunction, NotifyConnectedBind);
{ {
TableFunction tf("ui_is_started", {}, IsUIStartedTableFunc, TableFunction tf("ui_is_started", {}, IsUIStartedTableFunc,
SingleBoolResultBind, RunOnceTableFunctionState::Init); SingleBoolResultBind, RunOnceTableFunctionState::Init);