eric/duckdb-ui
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #24 from duckdb/yl/certs-checks

Browse Source 
Enable server certs verification by default
This commit is contained in:
Y.
2025-03-12 12:51:40 -04:00
committed by GitHub
parent 963e0e4d4c 8df6ff3728
commit 3e17531d0d
1 changed files with 1 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/http_server.cpp
View File

@@ -247,13 +247,7 @@ void HttpServer::HandleGet(const httplib::Request &req,
httplib::Client client(remote_url); httplib::Client client(remote_url);
client.set_keep_alive(true); client.set_keep_alive(true);
// Provide a way to turn on or off server certificate verification, at least if (IsEnvEnabled("ui_disable_server_certificate_verification")) {
// for now, because it requires httplib to correctly get the root certficates
// on each platform, which doesn't appear to always work. Currently, default
// to no verification, until we understand when it breaks things.
if (IsEnvEnabled("ui_enable_server_certificate_verification")) {
client.enable_server_certificate_verification(true);
} else {
client.enable_server_certificate_verification(false); client.enable_server_certificate_verification(false);
} }