eric/docker-getting-started
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
134 Commits 6 Branches 0 Tags 5.8 MiB
9b5581d3bd
Commit Graph

63 Commits

Author SHA1 Message Date
yuu
9b5581d3bd
Fix #76 
If the user runs that command "from the source code folder", i.e.
`getting-started`, docker will bind-mount getting-started to the
container's `/app`, which leads to error
`error Couldn't find a package.json file in "/app"`. It needs to bind
`getting-started/app` instead.
So, be explicit to the reader to be on the app source's directory
`getting-started/app` before running the command.
 2022-02-12 01:35:40 -03:00
Stefan Scherer
8725352c3f
Merge pull request #238 from lucasersson/patch-1 
Update index.md
 2022-02-09 12:19:45 +01:00
Stefan Scherer
f1f2012af5
Merge pull request #237 from ScottLozano/patch-2 
Update index.md
 2022-02-09 11:59:45 +01:00
lucasersson
9bf480301d
Update index.md 
updated readme to latest stable version of docker compose
 2022-01-12 13:00:46 +01:00
Scott Lozano
d35fc60923
Update index.md 2022-01-05 00:55:18 -08:00
Scott Lozano
6ab1ec709f
Update index.md 2022-01-05 00:17:24 -08:00
Stefan Scherer
56890c941a
Merge pull request #226 from SosukeHosokawa/master 
fix on 'Our Application' tutorial for Apple silicon
 2021-12-02 18:25:08 +01:00
Stefan Scherer
e96065a503
Merge pull request #145 from antalvarenga/master 
Multi-container apps: add workaround for non amd64 machines
 2021-12-02 07:30:06 +01:00
SosukeHosokawa
5c1574e643 fix on 'Our application' tutorial for Apple silicon 2021-11-24 01:24:18 +09:00
Stefan Scherer
42f8dbe70c
Merge pull request #187 from ollyhowell/patch-1 
Add reminder to save file for the app refresh change
 2021-11-12 09:25:15 +01:00
Stefan Scherer
5ded522cbf
Merge pull request #90 from spicylentils/patch-3 
Update docs/tutorial/using-bind-mounts/index.md
 2021-11-12 08:31:17 +01:00
Stefan Scherer
ace32adb9d
Merge pull request #120 from Patil2099/master 
Point To The Correct Link For Play With Docker
 2021-11-12 08:30:00 +01:00
Stefan Scherer
572dc47f99
Merge pull request #126 from GomolemoOnGithub/patch-1 
Period omission at the end of line 7,8 and 10.
 2021-11-12 08:20:13 +01:00
Stefan Scherer
5c65399cec
Merge pull request #113 from NicolaeTelescu/patch-1 
Update index.md from using bind mount
 2021-11-12 08:16:00 +01:00
Stefan Scherer
782d9421ae
Add dependencies for Apple silicon / M1 / arm64 builds 
Signed-off-by: Stefan Scherer <stefan.scherer@docker.com>
 2021-11-10 16:27:07 +01:00
Stefan Scherer
e04817f421
Merge pull request #178 from zuccamia/update-reference-urls 
Update reference links in docker compose section.
 2021-11-10 09:50:31 +01:00
Stefan Scherer
de74d48616
Merge pull request #163 from catnuxer/docs-persisting-our-data 
docs: Fix missing container id
 2021-11-10 09:41:14 +01:00
Spencer Adolph
acdcd83ced
Removed 'RUN apk add --no-cache python g++ make' 
This line did not appear to be necessary for the tutorial. Testing with it removed appeared to have no effect. Additionally, this line does not appear later in the tutorial when referring back to this step (see /docs/tutorial/image-building-best-practices/index.md).
 2021-10-21 12:57:36 -05:00
Oliver Howell
433353af1c
Add reminder to save file for the app refresh 2021-09-14 15:39:14 +01:00
Ngoc Hoang
67e75bb1cb Update reference links in docker compose section. 2021-08-11 21:49:23 +09:00
Chuli jimmi Manurung
9950c06246 docs: Fix missing container id 2021-06-13 21:39:07 +08:00
António Alvarenga
958126d5a7
add backtick 2021-05-07 11:33:02 +01:00
António Alvarenga
f390971d25
enclose code block in backticks 2021-05-07 11:31:51 +01:00
António Alvarenga
5d5e551104
Multi-container apps: add workaround for non amd64 machines 2021-05-07 11:26:18 +01:00
zipperer
e43a605d37 Edit docs/tutorial/using-bind-mounts/index.md 
'uses cases' |-> 'use cases'
 2021-03-09 08:49:09 +00:00
Stefan Scherer
eccb882c59 Add build tools to fix arm64 build issue 
Signed-off-by: Stefan Scherer <stefan.scherer@docker.com>
 2021-03-09 08:47:47 +00:00
Moses
dbae842f9c
Period omission at the end of line 7,8 and 10. The suggested bullet sign used "- " does not display 
Am using google chrome browser Version 88.0.4324.190 (Official Build) (64-bit)
 2021-03-02 07:51:54 +02:00
Pankaj Patil
dcfbefe0af
Point To The Correct Link For Play With Docker 2021-02-12 23:26:42 +05:30
Telescu Nicolae
e9f8d4443a
Update index.md 
The command for bind mount doesn't run in Ubuntu if the user is not in the source code folder. At least, for me didn't work. So I specified that to prevent errors and bugs.
 2021-01-20 11:06:02 +02:00
Stephen Turner
23e02b9a44
Add section on vulnerability scanning (#98) 
* Update index.md

* Add files via upload

* Update index.md

* Update docs/tutorial/image-building-best-practices/index.md

Co-authored-by: Usha Mandya <47779042+usha-mandya@users.noreply.github.com>

* Update index.md

Co-authored-by: Usha Mandya <47779042+usha-mandya@users.noreply.github.com>
 2020-11-02 12:24:36 +00:00
Tony Brown
9646231353 Update multi-container-apps env vars security typo 2020-10-22 09:07:54 +01:00
spicylentils
a2932698bd
Update docs/tutorial/using-bind-mounts/index.md 
Fix confusing wording regarding sources and destinations
 2020-09-28 17:01:39 -07:00
Stefan Scherer
6190776cb6
Merge pull request #77 from Fl4zher/fix-typo 
fixing typo
 2020-08-31 07:21:30 +02:00
Corey Garvey
bb961ef28d
Update docs w/ missing "to" 
Missing word in the docs
 2020-08-15 11:15:52 +01:00
Harun Kilic
0b402b3ebf
fixing typo 2020-08-07 02:09:28 +02:00
Stefan Scherer
a33ed89ab3
Quote volume mapping and use pwd 
Signed-off-by: Stefan Scherer <stefan.scherer@docker.com>
 2020-07-15 08:45:25 +02:00
Stefan Scherer
f77065be98
Show multiline PowerShell commands 
Signed-off-by: Stefan Scherer <stefan.scherer@docker.com>
 2020-07-15 08:20:44 +02:00
Stefan Scherer
3641a64e81
Merge pull request #65 from mattlevan/patch-1 
Fix slightly snide comment about SQLite
 2020-07-08 18:13:24 +02:00
Stefan Scherer
7cca5d6984
Merge pull request #66 from ffe4/patch-1 
Fix typo in tutorial
 2020-07-08 18:12:26 +02:00
Stefan Scherer
12a64fad04
Merge pull request #54 from klintzz/patch-1 
Dockerfile CMD path fix
 2020-07-08 18:11:35 +02:00
Kevin Lin
631465eee2
Removed leading slash 
Minor fix
 2020-07-08 08:52:39 -07:00
Daniel
3cf57a72b8
Fix typo in tutorial 2020-07-01 10:57:14 +02:00
Matthew Levan
f21aca690b
Fix slightly snide comment about SQLite 
The original language implies that SQLite is not an "actual" database engine, which is of course not the case! SQLite is a very capable and ubiquitous database engine. It's not appropriate for many applications, though, so perhaps the document here can simply read "different" rather than "actual". I recognize this is a bit particular, but hey-- that's how I perceived the language on my first read, and I don't even particularly like (or use) SQLite anyways! I do respect the technology, though, and thought it'd be kind to change the language so as to remove all possibility of misinterpretation.
 2020-06-30 09:50:26 -07:00
Kevin Lin
67a914066f
CMD update 2020-06-29 09:37:25 -07:00
Kevin Lin
28b0c3ccad
Additional CMD updates for dockerfiles 2020-06-29 09:30:32 -07:00
Stefan Scherer
c9ac9f27df
Merge pull request #50 from erichays/best-practices-fix 
Match output to input and clarify build command
 2020-06-29 10:54:46 +02:00
Kevin Lin
ab74008076
Dockerfile CMD path fix 
CMD runs relative to the WORKDIR.
 2020-06-04 13:21:09 -07:00
Eric Hays
1c571de3d5 Match output to input and clarify build command 
The Dockerfile listed above specifically uses package.json, but the
output listed for the build lists package*, which is inconsistent. The
React example later in the doc uses package*, which would be consistent
with the output, but this should fix the mismatch for the beginner going
through the tutorial for the first time.

Additionally, the sentence "Build the Docker image now using 'docker
build' again" might be confusing to a beginner. I specifically tested
running this exact command and it gives an error message. Specifically
using the exact command needed to build this target shouldn't take up
too much space.
 2020-06-03 02:10:30 +00:00
Dominik Mahnkopf
fc9025459a Add .dockerignore for node_modules & explanation 2020-06-02 22:07:07 +02:00
Eric Hays
55a83f8292 Fix typo in -v description 2020-05-28 09:33:05 +00:00